From: | Amit Kapila <akapila(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Use Enum for top level logical replication message types. |
Date: | 2020-11-02 02:57:47 |
Message-ID: | E1kZQ2V-0007DE-93@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Use Enum for top level logical replication message types.
Logical replication protocol uses a single byte character to identify a
message type in logical replication protocol. The code uses string
literals for the same. Use Enum so that
1. All the string literals used can be found at a single place. This
makes it easy to add more types without the risk of conflicts.
2. It's easy to locate the code handling a given message type.
3. When used with switch statements, it is easy to identify the missing
cases using -Wswitch.
Author: Ashutosh Bapat
Reviewed-by: Kyotaro Horiguchi, Andres Freund, Peter Smith and Amit Kapila
Discussion: https://postgr.es/m/CAExHW5uPzQ7L0oAd_ENyvaiYMOPgkrAoJpE+ZY5-obdcVT6NPg@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/644f0d7cc9c2cb270746f2024c706554e0fbec82
Modified Files
--------------
src/backend/replication/logical/proto.c | 26 +++++-----
src/backend/replication/logical/worker.c | 87 ++++++++++++++++----------------
src/include/replication/logicalproto.h | 27 ++++++++++
3 files changed, 83 insertions(+), 57 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-11-02 06:17:47 | pgsql: Fix some grammar and typos in comments and docs |
Previous Message | Michael Paquier | 2020-11-02 01:45:23 | pgsql: Extend PageIsVerified() to handle more custom options |