pgsql: pg_upgrade: generate check error for left-over new tablespace

From: Bruce Momjian <bruce(at)momjian(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_upgrade: generate check error for left-over new tablespace
Date: 2020-10-15 23:33:54
Message-ID: E1kTCks-0004vA-HY@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_upgrade: generate check error for left-over new tablespace

Previously, if pg_upgrade failed, and the user recreated the cluster but
did not remove the new cluster tablespace directory, a later pg_upgrade
would fail since the new tablespace directory would already exists.
This adds error reporting for this during check.

Reported-by: Justin Pryzby

Discussion: https://postgr.es/m/20200925005531.GJ23631@telsasoft.com

Backpatch-through: 9.5

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/59cfff65b10036b637a3f6e50d8f654e855d3b69

Modified Files
--------------
src/bin/pg_upgrade/check.c | 40 ++++++++++++++++++++++++++++++++++++++++
1 file changed, 40 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Bruce Momjian 2020-10-16 00:37:37 pgsql: pg_upgrade: remove C99 compiler req. from commit 3c0471b5fd
Previous Message Andres Freund 2020-10-15 22:22:35 pgsql: llvmjit: Also copy parameter / return value attributes from temp