From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Band-aid new postgres_fdw test case to remove error text depende |
Date: | 2020-10-10 23:57:32 |
Message-ID: | E1kROk0-0003SL-2q@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Band-aid new postgres_fdw test case to remove error text dependency.
Buildfarm member lorikeet is still failing the test from commit
32a9c0bdf, but now it's down to the should-have-foreseen-it problem
that the error message isn't what the expected-output file expects.
Let's see if we can get stable results by printing just the SQLSTATE.
I believe we'll reliably see ERRCODE_CONNECTION_FAILURE, since
pgfdw_report_error() will report that for any libpq-originated error.
There may be a better way to do this, but I'd like to get the
buildfarm back to green before we discuss further improvements.
Discussion: https://postgr.es/m/E1kPc9v-0005L4-2l@gemulon.postgresql.org
Discussion: https://postgr.es/m/2621622.1602184554@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/85d08b8b721fb3b9359bca9325bc425cc95c30b1
Modified Files
--------------
contrib/postgres_fdw/expected/postgres_fdw.out | 8 ++++----
contrib/postgres_fdw/sql/postgres_fdw.sql | 3 +++
2 files changed, 7 insertions(+), 4 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-10-11 00:16:16 | Re: pgsql: postgres_fdw: reestablish new connection if cached one is detect |
Previous Message | Tom Lane | 2020-10-10 19:34:01 | pgsql: Remove pointless error-code checking in pg_dump/parallel.c. |