From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix numeric width_bucket() to allow its first argument to be inf |
Date: | 2020-10-08 17:06:40 |
Message-ID: | E1kQZNI-0001nL-GE@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix numeric width_bucket() to allow its first argument to be infinite.
While the calculation is not well-defined if the bounds arguments are
infinite, there is a perfectly sane outcome if the test operand is
infinite: it's just like any other value that's before the first bucket
or after the last one. width_bucket_float8() got this right, but
I was too hasty about the case when adding infinities to numerics
(commit a57d312a7), so that width_bucket_numeric() just rejected it.
Fix that, and sync the relevant error message strings.
No back-patch needed, since infinities-in-numeric haven't shipped yet.
Discussion: https://postgr.es/m/2465409.1602170063@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/8ce423b1912b8303dbec5dc3ec78a7a725acf6c2
Modified Files
--------------
src/backend/utils/adt/numeric.c | 5 +++--
src/test/regress/expected/numeric.out | 17 +++++++++++++----
src/test/regress/sql/numeric.sql | 7 +++++--
3 files changed, 21 insertions(+), 8 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-10-08 20:00:18 | Re: pgsql: postgres_fdw: reestablish new connection if cached one is detect |
Previous Message | Tom Lane | 2020-10-08 13:47:20 | Re: pgsql: postgres_fdw: reestablish new connection if cached one is detect |