From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix optimization hazard in gram.y's makeOrderedSetArgs(), redux. |
Date: | 2020-10-07 22:43:22 |
Message-ID: | E1kQI9a-0003zb-N3@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix optimization hazard in gram.y's makeOrderedSetArgs(), redux.
It appears that commit cf63c641c, which intended to prevent
misoptimization of the result-building step in makeOrderedSetArgs,
didn't go far enough: buildfarm member hornet's version of xlc
is now optimizing back to the old, broken behavior in which
list_length(directargs) is fetched only after list_concat() has
changed that value. I'm not entirely convinced whether that's
an undeniable compiler bug or whether it can be justified by a
sufficiently aggressive interpretation of C sequence points.
So let's just change the code to make it harder to misinterpret.
Back-patch to all supported versions, just in case.
Discussion: https://postgr.es/m/1830491.1601944935@sss.pgh.pa.us
Branch
------
REL9_6_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/eb48619d01d77d8273f4effa64f7ad544db8bb35
Modified Files
--------------
src/backend/parser/gram.y | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2020-10-08 03:43:17 | Re: pgsql: postgres_fdw: reestablish new connection if cached one is detect |
Previous Message | Tom Lane | 2020-10-07 21:10:38 | pgsql: Prevent internal overflows in date-vs-timestamp and related comp |