pgsql: Display the names of missing columns in error during logical rep

From: Amit Kapila <akapila(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Display the names of missing columns in error during logical rep
Date: 2020-10-07 02:50:12
Message-ID: E1kPzWu-0005Wt-1d@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Display the names of missing columns in error during logical replication.

In logical replication when a subscriber is missing some columns, it
currently emits an error message that says "some" columns are missing, but
it doesn't specify the missing column names. Change that to display
missing column names which makes an error to be more informative to the
user.

We have decided not to backpatch this commit as this is a minor usability
improvement and no user has reported this.

Reported-by: Bharath Rupireddy
Author: Bharath Rupireddy
Reviewed-by: Kyotaro Horiguchi and Amit Kapila
Discussion: https://postgr.es/m/CALj2ACVkW-EXH_4pmBK8tNeHRz5ksUC4WddGactuCjPiBch-cg@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/f07707099c17e7ff66eac7d38cbd1148672f7ee4

Modified Files
--------------
src/backend/replication/logical/relation.c | 55 ++++++++++++++++++++++++------
1 file changed, 45 insertions(+), 10 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2020-10-07 03:54:13 Re: pgsql: postgres_fdw: reestablish new connection if cached one is detect
Previous Message Michael Paquier 2020-10-07 02:31:50 Re: pgsql: Fix race in test of pg_switch_wal().