pgsql: Improve stability of identity.sql regression test.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve stability of identity.sql regression test.
Date: 2020-10-05 00:46:56
Message-ID: E1kPEeW-00056F-Hn@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve stability of identity.sql regression test.

I noticed while trying to run the regression tests under a low
geqo_threshold that one query on information_schema.columns had
unstable (as in, variable from one run to the next) output order.
This is pretty unsurprising given the complexity of the underlying
plan. Interestingly, of this test's three nigh-identical queries on
information_schema.columns, the other two already had ORDER BY clauses
guaranteeing stable output. Let's make this one look the same.

Back-patch to v10 where this test was added. We've not heard field
reports of the test failing, but this experience shows that it can
happen when testing under even slightly unusual conditions.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e899742081fa24bf52d4a32103ef854a3a85865d

Modified Files
--------------
src/test/regress/expected/identity.out | 2 +-
src/test/regress/sql/identity.sql | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2020-10-05 07:35:38 pgsql: Support for OUT parameters in procedures
Previous Message Tom Lane 2020-10-05 00:46:36 pgsql: Improve stability of identity.sql regression test.