pgsql: Improve the error message for an inappropriate column definition

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve the error message for an inappropriate column definition
Date: 2020-09-22 14:49:22
Message-ID: E1kKjbe-0007tX-Np@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve the error message for an inappropriate column definition list.

The existing message about "a column definition list is only allowed for
functions returning "record"" could be given in some cases where it was
fairly confusing; in particular, a function with multiple OUT parameters
*does* return record according to pg_proc. Break it down into a couple
more cases to deliver a more on-point complaint. Per complaint from
Bruce Momjian.

Discussion: https://postgr.es/m/798909.1600562993@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ce90f075f0d831ca4085ba73891b7da2a2f7047e

Modified Files
--------------
src/backend/parser/parse_relation.c | 44 +++++++++++++++++++++++++++-----
src/test/regress/expected/rangefuncs.out | 13 ++++++++++
src/test/regress/sql/rangefuncs.sql | 5 ++++
3 files changed, 55 insertions(+), 7 deletions(-)

Responses

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-09-22 15:32:16 pgsql: Exclude fmgrprotos.h from pgindent processing.
Previous Message Tom Lane 2020-09-21 20:48:29 pgsql: Stamp 13.0.