| From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Code review for dynahash change. |
| Date: | 2020-09-19 03:55:20 |
| Message-ID: | E1kJTy4-0002Zj-2U@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Code review for dynahash change.
Commit be0a6666 left behind a comment about the order of some tests that
didn't make sense without the expensive division, and in fact we might
as well change the order to one that fails more cheaply most of the time
as a micro-optimization. Also, remove the "+ 1" applied to max_bucket,
to drop an instruction and match the original behavior. Per review
from Tom Lane.
Discussion: https://postgr.es/m/VI1PR0701MB696044FC35013A96FECC7AC8F62D0%40VI1PR0701MB6960.eurprd07.prod.outlook.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ff28809feb442eabd303955277f05cd16d9c6d8a
Modified Files
--------------
src/backend/utils/hash/dynahash.c | 7 +++----
1 file changed, 3 insertions(+), 4 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Peter Eisentraut | 2020-09-19 11:34:41 | pgsql: Remove unused parameters |
| Previous Message | Thomas Munro | 2020-09-18 23:54:24 | pgsql: Remove large fill factor support from dynahash.c. |