pgsql: Teach walsender to update its process title for replication comm

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Teach walsender to update its process title for replication comm
Date: 2020-09-17 01:06:56
Message-ID: E1kIiO0-0000cr-Nf@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Teach walsender to update its process title for replication commands.

Because the code path taken for SQL commands executed in a walsender
will update the process title, we pretty much have to update the
title for replication commands as well. Otherwise, the title shows
"idle" for the rest of a logical walsender's lifetime once it's
executed any SQL command.

Playing with this, I confirm that a walsender now typically spends
most of its life reporting
walsender postgres [local] START_REPLICATION
Considering this in isolation, it might be better to have it say
walsender postgres [local] sending replication data
However, consistency with the other cases seems to be a stronger
argument.

In passing, remove duplicative pgstat_report_activity call.

Discussion: https://postgr.es/m/880181.1600026471@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/babef40c9a999949abe0ae8e82240cac3f154237

Modified Files
--------------
src/backend/replication/walsender.c | 14 ++++++++++++--
1 file changed, 12 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-09-17 02:55:29 pgsql: Improve tab completion of IMPORT FOREIGN SCHEMA in psql
Previous Message Tom Lane 2020-09-17 00:31:52 pgsql: Improve formatting of create_help.pl and plperl_opmask.pl output