From: | Michael Paquier <michael(at)paquier(dot)xyz> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Avoid useless allocations for information of dumpable objects in |
Date: | 2020-09-14 01:44:44 |
Message-ID: | E1kHdXw-0007vv-Jr@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Avoid useless allocations for information of dumpable objects in pg_dump/
If there are no objects of a certain type, there is no need to do an
allocation for a set of DumpableObject items. The previous coding did
an allocation of 1 byte instead as per the fallback of pg_malloc() in
the event of an allocation size of zero. This assigns NULL instead for
a set of dumpable objects.
A similar rule already applied to findObjectByOid(), so this makes the
code more defensive as we would just fail with a pointer dereference
instead of attempting to use some incorrect data if a non-existing,
positive, OID is given by a caller of this function.
Author: Daniel Gustafsson
Reviewed-by: Julien Rouhaud, Ranier Vilela
Discussion: https://postgr.es/m/26C43E58-BDD0-4F1A-97CC-4A07B52E32C5@yesql.se
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/ac673a1aaff197f3e01f7bac69da0dd700854e13
Modified Files
--------------
src/bin/pg_dump/common.c | 3 +++
1 file changed, 3 insertions(+)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Eisentraut | 2020-09-14 04:53:56 | pgsql: Message fixes and style improvements |
Previous Message | Tom Lane | 2020-09-13 16:52:12 | pgsql: Use the properly transformed RangeVar for expandTableLikeClause( |