| From: | Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com> |
|---|---|
| To: | pgadmin-hackers(at)lists(dot)postgresql(dot)org |
| Subject: | pgAdmin 4 commit: Fixed code smell 'String literals should not be dupli |
| Date: | 2020-08-19 08:55:52 |
| Message-ID: | E1k8Jsu-0000at-1r@gothos.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgadmin-hackers |
Fixed code smell 'String literals should not be duplicated'.
Create a constant.py file which contains the common Constants.
Branch
------
master
Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=cc5a7ea334cd862ee54e4bc2f35026f40ea991d5
Author: Khushboo Vashi <khushboo(dot)vashi(at)enterprisedb(dot)com>
Modified Files
--------------
web/pgadmin/browser/__init__.py | 109 ++++++++++-----------
web/pgadmin/browser/collection.py | 13 +--
.../browser/register_browser_preferences.py | 43 ++++----
web/pgadmin/browser/server_groups/__init__.py | 28 +++---
.../browser/server_groups/servers/__init__.py | 24 ++---
.../server_groups/servers/databases/__init__.py | 11 ++-
.../servers/databases/event_triggers/__init__.py | 9 +-
.../foreign_servers/__init__.py | 13 +--
.../foreign_servers/user_mappings/__init__.py | 13 +--
web/pgadmin/browser/utils.py | 7 ++
web/pgadmin/utils/constants.py | 15 +++
11 files changed, 148 insertions(+), 137 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Akshay Joshi | 2020-08-19 08:56:57 | Re: [pgAdmin4][Patch] - SonarQube Fixes |
| Previous Message | Khushboo Vashi | 2020-08-19 08:31:01 | Re: [pgAdmin4][Patch] - SonarQube Fixes |