pgsql: Fix printing last progress report line in client programs.

From: Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix printing last progress report line in client programs.
Date: 2020-08-17 14:19:47
Message-ID: E1k7fzH-00006d-Mv@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix printing last progress report line in client programs.

A number of client programs have a "--progress" option that when printing
to a TTY, updates the current line by printing a '\r' and overwriting it.
After the last line, '\n' needs to be printed to move the cursor to the
next line. pg_basebackup and pgbench got this right, but pg_rewind and
pg_checksums were slightly wrong. pg_rewind printed the newline to stdout
instead of stderr, and pg_checksums printed the newline even when not
printing to a TTY. Fix them, and also add a 'finished' argument to
pg_basebackup's progress_report() function, to keep it consistent with
the other programs.

Backpatch to v12. pg_rewind's newline was broken with the logging changes
in commit cc8d415117 in v12, and pg_checksums was introduced in v12.

Discussion: https://www.postgresql.org/message-id/82b539e5-ae33-34b0-1aee-22b3379fd3eb@iki.fi

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/5ca1798f32b7fe730fef7ccd8d69e785a50134b8

Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 38 ++++++++++++++++++-----------------
src/bin/pg_checksums/pg_checksums.c | 14 ++++++-------
src/bin/pg_rewind/pg_rewind.c | 22 +++++++++++---------
src/bin/pg_rewind/pg_rewind.h | 2 +-
4 files changed, 41 insertions(+), 35 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-08-17 19:40:32 pgsql: Doc: fix description of UNION/CASE/etc type unification.
Previous Message Heikki Linnakangas 2020-08-17 07:55:03 pgsql: Mark commit and abort WAL records with XLR_SPECIAL_REL_UPDATE.