pgsql: Fix minor issues in psql's new \dAc and related commands.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix minor issues in psql's new \dAc and related commands.
Date: 2020-08-02 21:01:09
Message-ID: E1k2L6T-00021s-Vy@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix minor issues in psql's new \dAc and related commands.

The type-name pattern in \dAc and \dAf was matched only to the actual
pg_type.typname string, which is fairly user-unfriendly in cases where
that is not what's shown to the user by format_type (compare "_int4"
and "integer[]"). Make this code match what \dT does, i.e. match the
pattern against either typname or format_type() output. Also fix its
broken handling of schema-name restrictions. (IOW, make these
processSQLNamePattern calls match \dT's.) While here, adjust
whitespace to make the query a little prettier in -E output, too.

Also improve some inaccuracies and shaky grammar in the related
documentation.

Noted while working on a patch for intarray's opclasses; I wondered
why I couldn't get a match to "integer*" for the input type name.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/719304a3043d9f60247df371f55236058a7f3caa

Modified Files
--------------
doc/src/sgml/indices.sgml | 9 +++++++++
doc/src/sgml/ref/psql-ref.sgml | 38 ++++++++++++++++++++------------------
src/bin/psql/describe.c | 28 +++++++++++++++++++---------
3 files changed, 48 insertions(+), 27 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Thomas Munro 2020-08-03 00:24:17 pgsql: Correct comment in simplehash.h.
Previous Message Tom Lane 2020-08-02 15:00:21 pgsql: Adjust pgcrypto's expected test results for --disable-strong-ran