| From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Improve programmer docs for simplehash and dynahash. |
| Date: | 2020-08-01 00:16:26 |
| Message-ID: | E1k1fCM-00006h-6B@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Improve programmer docs for simplehash and dynahash.
When reading the code it's not obvious when one should prefer dynahash
over simplehash and vice-versa, so, for programmer-friendliness, add
comments to inform that decision.
Show sample simplehash method signatures.
Author: James Coleman <jtc331(at)gmail(dot)com>
Discussion: https://postgr.es/m/CAAaqYe_dOF39gAJ8rL-a3YO3Qo96MHMRQ2whFjK5ZcU6YvMQSA%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/84c0e4b9bce794da914fe9c062753bf21369745f
Modified Files
--------------
src/backend/utils/hash/dynahash.c | 12 ++++++-
src/include/lib/simplehash.h | 73 ++++++++++++++++++++++++++++++++++++---
2 files changed, 80 insertions(+), 5 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Michael Paquier | 2020-08-01 02:51:01 | pgsql: Minimize slot creation for multi-inserts of pg_shdepend |
| Previous Message | Peter Geoghegan | 2020-07-31 22:34:43 | pgsql: Restore lost amcheck TOAST test coverage. |