pgsql: Weaken type-OID-matching checks in array_recv and record_recv.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Weaken type-OID-matching checks in array_recv and record_recv.
Date: 2020-07-21 19:19:51
Message-ID: E1jxxnr-0003Mn-S8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Weaken type-OID-matching checks in array_recv and record_recv.

Rather than always insisting on an exact match of the type OID in the
data to the element type or column type we expect, complain only when
both OIDs fall within the manually-assigned range. This acknowledges
the reality that user-defined types don't have stable OIDs, while
still preserving some of the mistake-detection value of the old test.

(It's not entirely clear whether to error if one OID is manually
assigned and the other isn't. But perhaps that case could arise in
cross-version cases where a former extension type has been imported
into core, so I let it pass.)

This change allows us to remove the prohibition on binary transfer
of user-defined arrays and composites in the recently-landed support
for binary logical replication (commit 9de77b545). We can just
unconditionally drop that check, since if the client has asked for
binary transfer it must be >= v14 and must have this change.

Discussion: https://postgr.es/m/CADK3HH+R3xMn=8t3Ct+uD+qJ1KD=Hbif5NFMJ+d5DkoCzp6Vgw@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/670c0a1d474bf296dbcc1d6de912d4841f2ed643

Modified Files
--------------
src/backend/replication/logical/proto.c | 17 ++---------------
src/backend/utils/adt/arrayfuncs.c | 29 +++++++++++++++++++++++++----
src/backend/utils/adt/rowtypes.c | 28 ++++++++++++++++++++++++----
3 files changed, 51 insertions(+), 23 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Geoghegan 2020-07-21 22:51:42 pgsql: Add nbtree Valgrind buffer lock checks.
Previous Message Tom Lane 2020-07-21 17:13:55 pgsql: Avoid C99-ism in pre-v12 branches.