pgsql: Correctly mark pg_subscription_rel.srsublsn as nullable.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Correctly mark pg_subscription_rel.srsublsn as nullable.
Date: 2020-07-20 18:56:05
Message-ID: E1jxaxJ-0002hs-JR@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Correctly mark pg_subscription_rel.srsublsn as nullable.

The code has always set this column to NULL when it's not valid,
but the catalog header's description failed to reflect that,
as did the SGML docs, as did some of the code. To prevent future
coding errors of the same ilk, let's hide the field from C code
as though it were variable-length (which, in a sense, it is).

As with commit 72eab84a5, we can only fix this cleanly in HEAD
and v13; the problem extends further back but we'll need some
klugery in the released branches.

Discussion: https://postgr.es/m/367660.1595202498@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/0fa0b487b5d75d2b8576dec86a317212542642b8

Modified Files
--------------
doc/src/sgml/catalogs.sgml | 4 +++-
src/backend/catalog/pg_subscription.c | 18 ++++++++++++++++--
src/include/catalog/catversion.h | 2 +-
src/include/catalog/pg_subscription_rel.h | 14 ++++++++++++--
4 files changed, 32 insertions(+), 6 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-07-20 19:54:38 pgsql: Kluge slot_compile_deform() to ignore incorrect attnotnull marki
Previous Message Tom Lane 2020-07-20 17:40:36 pgsql: Fix construction of updated-columns bitmap in logical replicatio