pgsql: pg_dump: Reorganize dumpFunc() and dumpAgg()

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: pg_dump: Reorganize dumpFunc() and dumpAgg()
Date: 2020-07-15 13:05:15
Message-ID: E1jvh63-0002yD-K8@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

pg_dump: Reorganize dumpFunc() and dumpAgg()

Similar to daa9fe8a5264a3f192efa5ddee8fb011ad9da365, instead of
repeating the almost same large query in each version branch, use one
query and add a few columns to the SELECT list depending on the
version. This saves a lot of duplication.

Reviewed-by: Fabien COELHO <coelho(at)cri(dot)ensmp(dot)fr>
Discussion: https://www.postgresql.org/message-id/flat/6594334b-40fd-14f1-6bc5-877afa3feed5(at)2ndquadrant(dot)com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/ed2c7f65bd9f15f8f7cd21ad61602f983b1e72e9

Modified Files
--------------
src/bin/pg_dump/pg_dump.c | 496 +++++++++++++++-------------------------------
1 file changed, 159 insertions(+), 337 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2020-07-15 19:01:54 pgsql: doc: Fix typo
Previous Message Michael Paquier 2020-07-15 06:19:35 pgsql: Fix handling of missing files when using pg_rewind with online s