pgsql: Fix bugs in libpq's management of GSS encryption state.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix bugs in libpq's management of GSS encryption state.
Date: 2020-07-13 15:58:31
Message-ID: E1jv0qd-0002tG-7k@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix bugs in libpq's management of GSS encryption state.

GSS-related resources should be cleaned up in pqDropConnection,
not freePGconn, else the wrong things happen when resetting
a connection or trying to switch to a different server.
It's also critical to reset conn->gssenc there.

During connection setup, initialize conn->try_gss at the correct
place, else switching to a different server won't work right.

Remove now-redundant cleanup of GSS resources around one (and, for
some reason, only one) pqDropConnection call in connectDBStart.

Per report from Kyotaro Horiguchi that psql would freeze up,
rather than successfully resetting a GSS-encrypted connection
after a server restart.

This is YA oversight in commit b0b39f72b, so back-patch to v12.

Discussion: https://postgr.es/m/20200710.173803.435804731896516388.horikyota.ntt@gmail.com

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/8e6f134a9a8db52cbd2818ce8a60b9e5cdadfc8f

Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 37 +++++++++----------------------------
1 file changed, 9 insertions(+), 28 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Alexander Korotkov 2020-07-13 16:00:13 Re: pgsql: Improvements to psql \dAo and \dAp commands
Previous Message Alexander Korotkov 2020-07-13 15:57:59 pgsql: Improvements to psql \dAo and \dAp commands