| From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: HashAgg: before spilling tuples, set unneeded columns to NULL. |
| Date: | 2020-07-13 06:07:54 |
| Message-ID: | E1jurd4-0003nW-6e@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
HashAgg: before spilling tuples, set unneeded columns to NULL.
This is a replacement for 4cad2534. Instead of projecting all tuples
going into a HashAgg, only remove unnecessary attributes when actually
spilling. This avoids the regression for the in-memory case.
Discussion: https://postgr.es/m/a2fb7dfeb4f50aa0a123e42151ee3013933cb802.camel%40j-davis.com
Backpatch-through: 13
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2302302236a0c7aeba3377d78dd9d80ba53247df
Modified Files
--------------
src/backend/executor/nodeAgg.c | 123 ++++++++++++++++++++++++++++++-----------
src/include/nodes/execnodes.h | 8 ++-
2 files changed, 96 insertions(+), 35 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Jeff Davis | 2020-07-13 06:14:04 | pgsql: HashAgg: before spilling tuples, set unneeded columns to NULL. |
| Previous Message | Amit Kapila | 2020-07-13 03:32:08 | pgsql: Revert "Track statistics for spilling of changes from ReorderBuf |