From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Tighten up Windows CRLF conversion in our TAP test scripts. |
Date: | 2020-07-09 00:25:58 |
Message-ID: | E1jtKNy-0008HV-Ps@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Tighten up Windows CRLF conversion in our TAP test scripts.
The previous approach was to search-and-destroy all \r occurrences
no matter what. That seems more likely to hide bugs than anything
else; indeed it seems to be hiding one now. Fix things so that
we only transform \r\n to \n.
Side effects: must do this before, not after, chomp'ing if we're
going to chomp, else we'd fail to clean up a trailing \r\n. Also,
remove safe_psql's redundant repetition of what psql already did;
else it might reduce \r\r\n to \n, which is exactly the scenario
I'm hoping to expose.
Perhaps this should be back-patched, but for now I'm content to
see what happens in HEAD.
Discussion: https://postgr.es/m/412ae8da-76bb-640f-039a-f3513499e53d@gmx.net
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/91bdf499b37b0bbef34e2bab5cc40dde52bda52c
Modified Files
--------------
src/bin/pg_rewind/t/RewindTest.pm | 2 +-
src/test/perl/PostgresNode.pm | 13 ++++++-------
src/test/perl/TestLib.pm | 2 +-
3 files changed, 8 insertions(+), 9 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Fujii Masao | 2020-07-09 04:44:20 | pgsql: doc: Correct the description about the length of pg_stat_activit |
Previous Message | David Rowley | 2020-07-08 22:07:30 | pgsql: Fix whitespace in HashAgg EXPLAIN ANALYZE |