pgsql: Fix EXPLAIN ANALYZE for parallel HashAgg plans

From: David Rowley <drowley(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix EXPLAIN ANALYZE for parallel HashAgg plans
Date: 2020-06-19 05:26:08
Message-ID: E1jm9XU-00015I-Pl@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix EXPLAIN ANALYZE for parallel HashAgg plans

Since 1f39bce02, HashAgg nodes have had the ability to spill to disk when
memory consumption exceeds work_mem. That commit added new properties to
EXPLAIN ANALYZE to show the maximum memory usage and disk usage, however,
it didn't quite go as far as showing that information for parallel
workers. Since workers may have experienced something very different from
the main process, we should show this information per worker, as is done
in Sort.

Reviewed-by: Justin Pryzby
Reviewed-by: Jeff Davis
Discussion: https://postgr.es/m/CAApHDvpEKbfZa18mM1TD7qV6PG+w97pwCWq5tVD0dX7e11gRJw@mail.gmail.com
Backpatch-through: 13, where the hashagg spilling code was added.

Branch
------
REL_13_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/bdee4af8e07648008fe522fc5a562db453be5ad7

Modified Files
--------------
src/backend/commands/explain.c | 110 +++++++++++++++++++++++++++++++-----
src/backend/executor/execParallel.c | 19 ++++++-
src/backend/executor/nodeAgg.c | 103 +++++++++++++++++++++++++++++++++
src/include/executor/nodeAgg.h | 7 +++
src/include/nodes/execnodes.h | 22 ++++++++
5 files changed, 244 insertions(+), 17 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2020-06-19 08:21:19 pgsql: Fix issues in invalidation of obsolete replication slots.
Previous Message David Rowley 2020-06-19 05:24:55 pgsql: Fix EXPLAIN ANALYZE for parallel HashAgg plans