pgsql: Don't export basebackup.c's sendTablespace().

From: Robert Haas <rhaas(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Don't export basebackup.c's sendTablespace().
Date: 2020-06-17 15:04:31
Message-ID: E1jlZc7-0003V3-LG@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Don't export basebackup.c's sendTablespace().

Commit 72d422a5227ef6f76f412486a395aba9f53bf3f0 made xlog.c call
sendTablespace() with the 'sizeonly' argument set to true, which
required basebackup.c to export sendTablespace(). However, that's
kind of ugly, so instead defer the call to sendTablespace() until
basebackup.c regains control. That way, it can still be a static
function.

Patch by me, reviewed by Amit Kapila and Kyotaro Horiguchi.

Discussion: http://postgr.es/m/CA+TgmoYq+59SJ2zBbP891ngWPA9fymOqntqYcweSDYXS2a620A@mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1fa092913d260056b1aaf627ebc9cd9655c3a27c

Modified Files
--------------
src/backend/access/transam/xlog.c | 14 ++------------
src/backend/access/transam/xlogfuncs.c | 4 ++--
src/backend/replication/basebackup.c | 21 ++++++++++++++-------
src/include/access/xlog.h | 2 +-
src/include/replication/basebackup.h | 6 ------
5 files changed, 19 insertions(+), 28 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Robert Haas 2020-06-17 15:08:35 pgsql: Minor code cleanup for perform_base_backup().
Previous Message Peter Eisentraut 2020-06-17 07:59:08 pgsql: Remove STATUS_WAITING