pgsql: Lobotomize test for float -Inf ^ -2, at least for now.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Lobotomize test for float -Inf ^ -2, at least for now.
Date: 2020-06-16 19:29:12
Message-ID: E1jlHGi-0004oo-Vz@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Lobotomize test for float -Inf ^ -2, at least for now.

Per POSIX this case should produce +0, but buildfarm member fossa
(with icc (ICC) 19.0.5.281 20190815) is reporting -0. icc has a
boatload of unsafe floating-point optimizations, with a corresponding
boatload of not-too-well-documented compiler switches, and it seems our
default use of "-mp1" isn't whacking it hard enough to keep it from
misoptimizing the stanza in dpow() that checks whether y is odd.
There's nothing wrong with that code (seeing that no other buildfarm
member has trouble with it), so I'm content to blame this on the
compiler. But without access to the compiler I'm not going to guess at
what switches might be needed to fix it. For now, tweak the test case
so it will accept either -0 or +0 as a correct answer.

Discussion: https://postgr.es/m/E1jkyFX-0005RR-1Q@gemulon.postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/3a990a1263560ef28707bc623e875e75ae42041c

Modified Files
--------------
src/test/regress/expected/float8.out | 10 ++++++----
src/test/regress/sql/float8.sql | 4 +++-
2 files changed, 9 insertions(+), 5 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-06-16 20:42:08 pgsql: Doc: fix copy-and-pasteo in ecpg docs.
Previous Message Peter Eisentraut 2020-06-16 15:29:01 pgsql: Fix file reference in nls.mk