From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix buffile.c error handling. |
Date: | 2020-06-16 05:28:21 |
Message-ID: | E1jl48z-0007wh-LR@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix buffile.c error handling.
Convert buffile.c error handling to use ereport. This fixes cases where
I/O errors were indistinguishable from EOF or not reported. Also remove
"%m" from error messages where errno would be bogus. While we're
modifying those strings, add block numbers and short read byte counts
where appropriate.
Back-patch to all supported releases.
Reported-by: Amit Khandekar <amitdkhan(dot)pg(at)gmail(dot)com>
Reviewed-by: Melanie Plageman <melanieplageman(at)gmail(dot)com>
Reviewed-by: Alvaro Herrera <alvherre(at)2ndquadrant(dot)com>
Reviewed-by: Robert Haas <robertmhaas(at)gmail(dot)com>
Reviewed-by: Ibrar Ahmed <ibrar(dot)ahmad(at)gmail(dot)com>
Reviewed-by: Michael Paquier <michael(at)paquier(dot)xyz>
Discussion: https://postgr.es/m/CA%2BhUKGJE04G%3D8TLK0DLypT_27D9dR8F1RQgNp0jK6qR0tZGWOw%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7897e3bb902c557412645b82120f4d95f7474906
Modified Files
--------------
src/backend/access/gist/gistbuildbuffers.c | 24 +++++--------
src/backend/executor/nodeHashjoin.c | 24 +++++--------
src/backend/replication/backup_manifest.c | 9 ++---
src/backend/storage/file/buffile.c | 45 ++++++++++++------------
src/backend/utils/sort/logtape.c | 19 ++++++----
src/backend/utils/sort/sharedtuplestore.c | 21 +++++------
src/backend/utils/sort/tuplestore.c | 56 +++++++++++++-----------------
7 files changed, 88 insertions(+), 110 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2020-06-16 05:28:44 | pgsql: Fix buffile.c error handling. |
Previous Message | Peter Eisentraut | 2020-06-16 03:14:52 | pgsql: doc: Document factorial function |