| From: | Robert Haas <rhaas(at)postgresql(dot)org> |
|---|---|
| To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
| Subject: | pgsql: Assorted cleanup of tar-related code. |
| Date: | 2020-06-15 20:48:46 |
| Message-ID: | E1jkw2A-0004YX-9f@gemulon.postgresql.org |
| Views: | Raw Message | Whole Thread | Download mbox | Resend email |
| Thread: | |
| Lists: | pgsql-committers |
Assorted cleanup of tar-related code.
Introduce TAR_BLOCK_SIZE and replace many instances of 512 with
the new constant. Introduce function tarPaddingBytesRequired
and use it to replace numerous repetitions of (x + 511) & ~511.
Add preprocessor guards against multiple inclusion to pgtar.h.
Reformat the prototype for tarCreateHeader so it doesn't extend
beyond 80 characters.
Discussion: http://postgr.es/m/CA+TgmobWbfReO9-XFk8urR1K4wTNwqoHx_v56t7=T8KaiEoKNw@mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/2961c9711c17e5fe05fb1fbd72c3e47f3b601ee4
Modified Files
--------------
src/backend/replication/basebackup.c | 29 ++++++++++++++--------
src/bin/pg_basebackup/pg_basebackup.c | 46 +++++++++++++++++------------------
src/bin/pg_basebackup/walmethods.c | 25 +++++++++++--------
src/bin/pg_dump/pg_backup_tar.c | 30 ++++++++++++-----------
src/include/pgtar.h | 23 ++++++++++++++++--
5 files changed, 94 insertions(+), 59 deletions(-)
| From | Date | Subject | |
|---|---|---|---|
| Next Message | Tom Lane | 2020-06-15 23:10:43 | pgsql: Fix power() for large inputs yet more. |
| Previous Message | Tom Lane | 2020-06-15 16:16:04 | pgsql: Fix power() for infinity inputs some more. |