pgsql: Create by default sql/ and expected/ for output directory in pg_

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Create by default sql/ and expected/ for output directory in pg_
Date: 2020-06-13 05:05:19
Message-ID: E1jjyM3-0006AY-6z@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Create by default sql/ and expected/ for output directory in pg_regress

Using --outputdir with a custom output repository has never created by
default the sql/ and expected/ paths generated with contents from
respectively input/ and output/ if they don't exist, while the base
output directory gets created if it does not exist. If sql/ and
expected/ are not present, pg_regress would fail with the path missing,
requiring test scripts to create those extra paths by themselves. This
commit changes pg_regress so as both get created by default if they do
not exist, removing the need for external test scripts to do so.

This cleans up two code paths in the tree for pg_upgrade tests in MSVC
and environments able to use test.sh. sql/ and expected/ were created
as part of each test script, but this is not needed anymore as
pg_regress handles the work now.

Author: Roman Zharkov, Daniel Gustafsson
Reviewed-by: Michael Paquier, Tom Lane
Discussion: https://postgr.es/m/16484-4d89e9cc11241996@postgresql.org

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e78900afd217fa3eaa77c51e23a94c1466af421c

Modified Files
--------------
src/bin/pg_upgrade/test.sh | 2 --
src/test/regress/pg_regress.c | 11 +++++++----
src/tools/msvc/vcregress.pl | 2 --
3 files changed, 7 insertions(+), 8 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2020-06-13 07:22:13 pgsql: Refactor AlterExtensionContentsStmt grammar
Previous Message Michael Paquier 2020-06-13 00:35:58 pgsql: Add more TAP tests for pg_dump options with range checks