From: | David Rowley <drowley(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Have pg_itoa, pg_ltoa and pg_lltoa return the length of the stri |
Date: | 2020-06-13 00:32:26 |
Message-ID: | E1jju5y-0004XR-J8@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Have pg_itoa, pg_ltoa and pg_lltoa return the length of the string
Core by no means makes excessive use of these functions, but quite a large
number of those usages do require the caller to call strlen() on the
returned string. This is quite wasteful since these functions do already
have a good idea of the length of the string, so we might as well just
have them return that.
Reviewed-by: Andrew Gierth
Discussion: https://postgr.es/m/CAApHDvrm2A5x2uHYxsqriO2cUaGcFvND%2BksC9e7Tjep0t2RK_A%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/dad75eb4a8d5835ecc795d7a7978e7702e4d5912
Modified Files
--------------
src/backend/access/common/printsimple.c | 10 ++++++----
src/backend/utils/adt/int.c | 4 +---
src/backend/utils/adt/int8.c | 11 +++++++++--
src/backend/utils/adt/numutils.c | 32 +++++++++++++++++++-------------
src/include/utils/builtins.h | 6 +++---
5 files changed, 38 insertions(+), 25 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-06-13 00:35:58 | pgsql: Add more TAP tests for pg_dump options with range checks |
Previous Message | David Rowley | 2020-06-12 23:28:49 | pgsql: Add missing extern keyword for a couple of numutils functions |