pgsql: Initial pgindent and pgperltidy run for v13.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Initial pgindent and pgperltidy run for v13.
Date: 2020-05-14 17:07:05
Message-ID: E1jZHK5-0005CQ-To@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Initial pgindent and pgperltidy run for v13.

Includes some manual cleanup of places that pgindent messed up,
most of which weren't per project style anyway.

Notably, it seems some people didn't absorb the style rules of
commit c9d297751, because there were a bunch of new occurrences
of function calls with a newline just after the left paren, all
with faulty expectations about how the rest of the call would get
indented.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/5cbfce562f7cd2aab0cdc4694ce298ec3567930e

Modified Files
--------------
contrib/adminpack/adminpack.c | 2 +-
contrib/intarray/_int_bool.c | 4 +-
contrib/ltree/_ltree_gist.c | 4 +-
contrib/ltree/ltree.h | 2 +-
contrib/ltree/ltree_gist.c | 6 +-
contrib/pg_stat_statements/pg_stat_statements.c | 1 +
contrib/pg_visibility/pg_visibility.c | 2 +-
contrib/postgres_fdw/connection.c | 5 +-
contrib/postgres_fdw/option.c | 12 +-
doc/src/sgml/mk_feature_tables.pl | 6 +-
src/backend/access/common/detoast.c | 19 +-
src/backend/access/gist/gist.c | 11 +-
src/backend/access/hash/hashutil.c | 1 +
src/backend/access/hash/hashvalidate.c | 2 +-
src/backend/access/heap/heapam.c | 4 +-
src/backend/access/index/indexam.c | 4 +-
src/backend/access/nbtree/nbtpage.c | 13 +-
src/backend/access/nbtree/nbtree.c | 3 +-
src/backend/access/nbtree/nbtsearch.c | 9 +-
src/backend/access/nbtree/nbtsplitloc.c | 2 +-
src/backend/access/rmgrdesc/dbasedesc.c | 2 +-
src/backend/access/rmgrdesc/xactdesc.c | 4 +-
src/backend/access/spgist/spgvalidate.c | 2 +-
src/backend/access/transam/xact.c | 6 +-
src/backend/access/transam/xlog.c | 23 +-
src/backend/access/transam/xlogarchive.c | 4 +-
src/backend/access/transam/xlogreader.c | 10 +-
src/backend/catalog/genbki.pl | 6 +-
src/backend/catalog/heap.c | 8 +-
src/backend/catalog/pg_cast.c | 14 +-
src/backend/catalog/pg_depend.c | 4 +-
src/backend/catalog/pg_shdepend.c | 2 +
src/backend/catalog/storage.c | 22 +-
src/backend/commands/alter.c | 2 +-
src/backend/commands/dbcommands.c | 10 +-
src/backend/commands/event_trigger.c | 6 -
src/backend/commands/explain.c | 16 +-
src/backend/commands/extension.c | 56 ++--
src/backend/commands/functioncmds.c | 2 +-
src/backend/commands/opclasscmds.c | 5 +-
src/backend/commands/publicationcmds.c | 8 +-
src/backend/commands/statscmds.c | 8 +-
src/backend/commands/tablecmds.c | 23 +-
src/backend/commands/trigger.c | 4 +-
src/backend/executor/execExpr.c | 2 +-
src/backend/executor/execExprInterp.c | 80 +++--
src/backend/executor/execGrouping.c | 14 +-
src/backend/executor/execSRF.c | 6 +-
src/backend/executor/execUtils.c | 6 +-
src/backend/executor/nodeAgg.c | 323 +++++++++++----------
src/backend/executor/nodeBitmapHeapscan.c | 4 +-
src/backend/executor/nodeIncrementalSort.c | 71 +++--
src/backend/executor/nodeTidscan.c | 2 +-
src/backend/jit/llvm/llvmjit_expr.c | 41 ++-
src/backend/libpq/auth-scram.c | 18 +-
src/backend/libpq/be-secure-openssl.c | 5 +-
src/backend/libpq/crypt.c | 2 +-
src/backend/optimizer/path/allpaths.c | 41 +--
src/backend/optimizer/path/costsize.c | 62 ++--
src/backend/optimizer/path/joinrels.c | 21 +-
src/backend/optimizer/path/pathkeys.c | 2 +-
src/backend/optimizer/plan/planner.c | 70 ++---
src/backend/parser/parse_clause.c | 2 +-
src/backend/parser/parse_utilcmd.c | 4 +-
src/backend/partitioning/partbounds.c | 277 +++++++++---------
src/backend/partitioning/partprune.c | 4 +-
src/backend/postmaster/autovacuum.c | 2 +-
src/backend/postmaster/checkpointer.c | 22 +-
src/backend/postmaster/pgstat.c | 12 +-
src/backend/postmaster/postmaster.c | 2 +
src/backend/replication/backup_manifest.c | 12 +-
src/backend/replication/logical/relation.c | 2 +-
src/backend/replication/pgoutput/pgoutput.c | 13 +-
src/backend/replication/slotfuncs.c | 13 +-
src/backend/replication/walreceiverfuncs.c | 8 +-
src/backend/replication/walsender.c | 6 +-
src/backend/statistics/dependencies.c | 14 +-
src/backend/statistics/extended_stats.c | 72 ++---
src/backend/statistics/mcv.c | 108 +++----
src/backend/storage/buffer/bufmgr.c | 2 +-
src/backend/storage/freespace/freespace.c | 6 +-
src/backend/storage/ipc/latch.c | 6 +-
src/backend/storage/ipc/procarray.c | 4 +-
src/backend/storage/ipc/procsignal.c | 80 ++---
src/backend/storage/ipc/shmem.c | 4 +-
src/backend/storage/lmgr/lock.c | 2 +-
src/backend/storage/smgr/smgr.c | 12 +-
src/backend/tcop/utility.c | 44 +--
src/backend/utils/adt/datetime.c | 16 +-
src/backend/utils/adt/int.c | 19 +-
src/backend/utils/adt/int8.c | 19 +-
src/backend/utils/adt/json.c | 2 +-
src/backend/utils/adt/jsonfuncs.c | 13 +-
src/backend/utils/adt/numutils.c | 32 +-
src/backend/utils/adt/pgstatfuncs.c | 14 +-
src/backend/utils/adt/rangetypes_spgist.c | 10 +-
src/backend/utils/adt/regproc.c | 3 +-
src/backend/utils/adt/ruleutils.c | 16 +-
src/backend/utils/adt/tsgistidx.c | 12 +-
src/backend/utils/cache/lsyscache.c | 8 +-
src/backend/utils/cache/relcache.c | 11 +-
src/backend/utils/error/elog.c | 4 +-
src/backend/utils/hash/dynahash.c | 5 +-
src/backend/utils/init/miscinit.c | 2 +-
src/backend/utils/misc/guc.c | 2 +-
src/backend/utils/mmgr/aset.c | 10 +-
src/backend/utils/mmgr/mcxt.c | 2 +-
src/backend/utils/mmgr/slab.c | 7 +-
src/backend/utils/sort/logtape.c | 45 +--
src/backend/utils/sort/tuplesort.c | 14 +-
src/bin/initdb/initdb.c | 20 +-
src/bin/pg_basebackup/pg_basebackup.c | 5 +-
src/bin/pg_basebackup/t/010_pg_basebackup.pl | 13 +-
src/bin/pg_checksums/pg_checksums.c | 2 +-
src/bin/pg_dump/pg_dump.c | 26 +-
src/bin/pg_dump/pg_dump.h | 4 +-
src/bin/pg_dump/t/002_pg_dump.pl | 12 +-
src/bin/pg_dump/t/003_pg_dump_with_server.pl | 16 +-
src/bin/pg_rewind/libpq_fetch.c | 2 +-
src/bin/pg_verifybackup/parse_manifest.h | 20 +-
src/bin/pg_verifybackup/pg_verifybackup.c | 11 +-
src/bin/pg_verifybackup/t/001_basic.pl | 29 +-
src/bin/pg_verifybackup/t/002_algorithm.pl | 16 +-
src/bin/pg_verifybackup/t/003_corruption.pl | 113 +++----
src/bin/pg_verifybackup/t/004_options.pl | 87 +++---
src/bin/pg_verifybackup/t/005_bad_manifest.pl | 20 +-
src/bin/pg_verifybackup/t/006_encoding.pl | 24 +-
src/bin/pg_verifybackup/t/007_wal.pl | 33 ++-
src/bin/pgbench/pgbench.c | 8 +-
src/bin/pgbench/t/001_pgbench_with_server.pl | 132 +++++----
src/bin/pgbench/t/002_pgbench_no_server.pl | 25 +-
src/bin/psql/common.c | 2 +-
src/bin/psql/describe.c | 2 +-
src/bin/psql/mainloop.c | 9 +-
src/bin/psql/tab-complete.c | 4 +-
src/bin/scripts/createuser.c | 4 +-
src/bin/scripts/t/090_reindexdb.pl | 2 +-
src/bin/scripts/t/100_vacuumdb.pl | 3 +-
src/common/jsonapi.c | 16 +-
src/common/pg_lzcompress.c | 2 +-
src/common/scram-common.c | 2 +-
src/common/unicode/generate-norm_test_table.pl | 3 +-
.../unicode/generate-unicode_combining_table.pl | 51 ++--
src/common/unicode/generate-unicode_norm_table.pl | 4 +-
.../unicode/generate-unicode_normprops_table.pl | 10 +-
src/common/unicode_norm.c | 22 +-
src/include/access/tableam.h | 8 +-
src/include/access/visibilitymap.h | 2 +-
src/include/catalog/pg_publication.h | 2 +-
src/include/catalog/pg_statistic_ext.h | 2 +-
src/include/commands/dbcommands_xlog.h | 2 +-
src/include/common/scram-common.h | 2 +-
src/include/common/unicode_normprops_table.h | 2 +-
src/include/executor/nodeAgg.h | 11 +-
src/include/lib/simplehash.h | 12 +-
src/include/libpq/libpq-be.h | 2 +-
src/include/libpq/scram.h | 2 +-
src/include/nodes/execnodes.h | 22 +-
src/include/nodes/params.h | 6 +-
src/include/nodes/pathnodes.h | 6 +-
src/include/nodes/plannodes.h | 2 +-
src/include/port.h | 2 +-
src/include/port/win32.h | 2 +-
src/include/replication/backup_manifest.h | 2 +-
src/include/replication/logicalrelation.h | 2 +-
src/include/replication/walreceiver.h | 10 +-
src/include/statistics/extended_stats_internal.h | 2 +-
src/include/statistics/statistics.h | 4 +-
src/include/storage/shmem.h | 2 +-
src/include/utils/lsyscache.h | 2 +-
src/include/utils/rangetypes.h | 8 +-
src/interfaces/ecpg/compatlib/informix.c | 4 +-
src/interfaces/ecpg/pgtypeslib/dt_common.c | 3 +-
src/interfaces/ecpg/pgtypeslib/timestamp.c | 3 +-
src/interfaces/libpq/fe-auth-scram.c | 2 +-
src/interfaces/libpq/fe-secure-openssl.c | 37 ++-
src/interfaces/libpq/libpq-fe.h | 4 +-
src/pl/tcl/pltcl.c | 10 +-
src/port/explicit_bzero.c | 2 +-
src/test/authentication/t/001_password.pl | 3 +-
src/test/authentication/t/002_saslprep.pl | 3 +-
src/test/modules/dummy_index_am/dummy_index_am.c | 11 +-
.../ssl_passphrase_callback/ssl_passphrase_func.c | 6 +-
src/test/perl/PostgresNode.pm | 5 +-
src/test/perl/TestLib.pm | 4 +-
src/test/recovery/t/001_stream_rep.pl | 23 +-
src/test/recovery/t/003_recovery_targets.pl | 22 +-
src/test/recovery/t/006_logical_decoding.pl | 22 +-
src/test/recovery/t/019_replslot_limit.pl | 89 ++++--
src/test/ssl/t/001_ssltests.pl | 47 +--
src/test/subscription/t/003_constraints.pl | 6 +-
src/test/subscription/t/008_diff_schema.pl | 17 +-
src/test/subscription/t/013_partition.pl | 280 ++++++++----------
src/tools/msvc/Mkvcbuild.pm | 32 +-
src/tools/msvc/Solution.pm | 31 +-
src/tools/msvc/vcregress.pl | 4 +-
src/tools/pgindent/typedefs.list | 128 ++++++--
src/tools/version_stamp.pl | 10 +-
198 files changed, 2021 insertions(+), 1788 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-05-14 22:44:36 pgsql: Doc: hack on table 26.1 till it fits in PDF format.
Previous Message Bruce Momjian 2020-05-14 15:51:21 pgsql: doc: PG 13 relnotes: move docbook version change to doc sect.