From: | Heikki Linnakangas <heikki(dot)linnakangas(at)iki(dot)fi> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Move check for fsync=off so that pendingOps still gets cleared. |
Date: | 2020-05-14 05:41:13 |
Message-ID: | E1jZ6cL-000071-VL@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Move check for fsync=off so that pendingOps still gets cleared.
Commit 3eb77eba5a moved the loop and refactored it, and inadvertently
changed the effect of fsync=off so that it also skipped removing entries
from the pendingOps table. That was not intentional, and leads to an
assertion failure if you turn fsync on while the server is running and
reload the config.
Backpatch-through: 12-
Reviewed-By: Thomas Munro
Discussion: https://www.postgresql.org/message-id/3cbc7f4b-a5fa-56e9-9591-c886deb07513%40iki.fi
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/e8abf585ab453ca9c2f66f2138baf6d3c9c8fbf0
Modified Files
--------------
src/backend/storage/sync/sync.c | 148 ++++++++++++++++++++--------------------
1 file changed, 75 insertions(+), 73 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Alexander Korotkov | 2020-05-14 09:52:10 | Re: pgsql: Show opclass and opfamily related information in psql |
Previous Message | Amit Kapila | 2020-05-14 04:29:06 | pgsql: Fix the MSVC build for versions 2015 and later. |