pgsql: Clear up issue with FSM and oldest bpto.xact.

From: Peter Geoghegan <pg(at)bowt(dot)ie>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Clear up issue with FSM and oldest bpto.xact.
Date: 2020-05-01 19:21:30
Message-ID: E1jUbE2-0004v1-Fu@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Clear up issue with FSM and oldest bpto.xact.

On further reflection, code comments added by commit b0229f26 slightly
misrepresented how we determine the oldest bpto.xact for the index.
btvacuumpage() does not treat the bpto.xact of a page that it put in the
FSM as a candidate to be the oldest deleted page (the delete-marked page
that has the oldest bpto.xact XID among all pages encountered).

The definition of a deleted page for the purposes of the bpto.xact
calculation is different from the definition used by the bulk delete
statistics. The bulk delete statistics don't distinguish between pages
that were deleted by the current VACUUM, pages deleted by a previous
VACUUM operation but not yet recyclable/reusable, and pages that are
reusable (though reusable pages are counted separately).

Backpatch: 11-, just like commit b0229f26.

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/573478564705a801f7313bb793f05932cb875528

Modified Files
--------------
src/backend/access/nbtree/nbtree.c | 30 +++++++++++++++---------------
1 file changed, 15 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-05-01 20:17:02 pgsql: Doc: update sections 9.17 - 9.21 for new function table layout.
Previous Message Peter Geoghegan 2020-05-01 17:04:37 pgsql: Reorder function prototypes for consistency.