From: | Alvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Check slot->restart_lsn validity in a few more places |
Date: | 2020-04-29 00:42:46 |
Message-ID: | E1jTaoI-0001pn-OO@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Check slot->restart_lsn validity in a few more places
Lack of these checks could cause visible misbehavior, including
assertion failures. This was missed in commit c6550776394e, whereby
restart_lsn becomes invalid when the size limit is exceeded.
Also reword some existing error messages, and add errdetail(), so that
the reported errors all match in spirit.
Author: Kyotaro Horiguchi <horikyota(dot)ntt(at)gmail(dot)com>
Reviewed-by: Álvaro Herrera <alvherre(at)alvh(dot)no-ip(dot)org>
Discussion: https://postgr.es/m/20200408.093710.447591748588426656.horikyota.ntt@gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/d0abe78d84274cc203f3d117b8006dc2164ca31a
Modified Files
--------------
contrib/test_decoding/expected/slot.out | 3 ++-
src/backend/replication/logical/logicalfuncs.c | 13 +++++++++++++
src/backend/replication/slotfuncs.c | 4 +++-
src/backend/replication/walsender.c | 14 +++++++++++++-
4 files changed, 31 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Amit Kapila | 2020-04-29 07:05:24 | Re: pgsql: Remove some code for old unsupported versions of MSVC |
Previous Message | Peter Geoghegan | 2020-04-28 23:13:58 | pgsql: Add LP_DEAD deletion of a posting list tuple test. |