From: | Robert Haas <rhaas(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix bogus tar-file padding logic for standby.signal. |
Date: | 2020-04-27 18:07:20 |
Message-ID: | E1jT8A4-0002DF-Nq@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix bogus tar-file padding logic for standby.signal.
When pg_basebackup -R is used, we inject standby.signal into the
tar file for the main tablespace. The proper thing to do is to pad
each file injected into the tar file out to a 512-byte boundary
by appending nulls, but here the file is of length 0 and we add
511 zero bytes. Since 0 is already a multiple of 512, we should
not add any zero bytes. Do that instead.
Patch by me, reviewed by Tom Lane.
Discussion: http://postgr.es/m/CA+TgmobWbfReO9-XFk8urR1K4wTNwqoHx_v56t7=T8KaiEoKNw@mail.gmail.com
Branch
------
REL_12_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/a08bfe7424929fcba4af9eb8ca80214eca47159a
Modified Files
--------------
src/bin/pg_basebackup/pg_basebackup.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Michael Paquier | 2020-04-27 22:58:53 | pgsql: Add more TAP coverage for archive status with crash recovery of |
Previous Message | Tom Lane | 2020-04-27 16:21:24 | pgsql: Fix full text search to handle NOT above a phrase search correct |