From: | Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix cost_incremental_sort for expressions with varno 0 |
Date: | 2020-04-22 22:44:55 |
Message-ID: | E1jRO6x-0001Xt-6m@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix cost_incremental_sort for expressions with varno 0
When estimating the number of pre-sorted groups in cost_incremental_sort
we must not pass Vars with varno 0 to estimate_num_groups, which would
cause failues in find_base_rel. This may happen when sorting output of
set operations, thanks to generate_append_tlist.
Unlike recurse_set_operations we can't easily access the original target
list, so if we find any Vars with varno 0, we fall back to the default
estimate DEFAULT_NUM_DISTINCT.
Reported-by: Justin Pryzby
Discussion: https://postgr.es/m/20200411214639.GK2228%40telsasoft.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/de0dc1a84710f127fdd40f87e783797cc2d69a77
Modified Files
--------------
src/backend/optimizer/path/costsize.c | 54 ++++++++++++++++++++++++--
src/test/regress/expected/incremental_sort.out | 20 ++++++++++
src/test/regress/sql/incremental_sort.sql | 4 ++
3 files changed, 75 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Peter Geoghegan | 2020-04-22 23:12:09 | pgsql: nbtree: Rename BT_RESERVED_OFFSET_MASK. |
Previous Message | Bruce Momjian | 2020-04-22 20:23:27 | pgsql: docs: land height is "elevation", not "altitude" |