pgAdmin 4 commit: Fixed validation errors in view/materialized view jav

From: Ashesh Vashi <ashesh(dot)vashi(at)enterprisedb(dot)com>
To: pgadmin-hackers(at)lists(dot)postgresql(dot)org
Subject: pgAdmin 4 commit: Fixed validation errors in view/materialized view jav
Date: 2020-04-22 11:54:09
Message-ID: E1jRDxB-00011j-80@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Fixed validation errors in view/materialized view javascript to
determine the number columns chagned. It was trying to execute
'replace' and 'includes' function on undefined values instead of
string value.

Also - changed the warning message, and separated the 'Do you want to
continue?' syntax in separate line for better user experience.

Fixes #5053

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=858294f36e81fddf5da2f1538129cc2030b7d724

Modified Files
--------------
.../databases/schemas/views/static/js/mview.js | 5 ++-
.../databases/schemas/views/static/js/view.js | 51 ++++++++++++++--------
2 files changed, 38 insertions(+), 18 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Neel Patel 2020-04-22 11:55:37 Re: RM4292 - Dark mode support for Windows/macOS
Previous Message Dave Page 2020-04-22 11:42:40 Re: RM4292 - Dark mode support for Windows/macOS