pgsql: Fix minor memory leak in pg_basebackup and pg_receivewal

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix minor memory leak in pg_basebackup and pg_receivewal
Date: 2020-04-17 01:47:13
Message-ID: E1jPG65-0003rn-Ci@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix minor memory leak in pg_basebackup and pg_receivewal

The result of the query used to retrieve the WAL segment size from the
backend was not getting freed in two code paths. Both pg_basebackup and
pg_receivewal exit immediately if a failure happened on this query, so
this was not an actual problem, but it could be an issue if this code
gets used for other tools in different ways, be they future tools in
this code tree or external, existing, ones.

Oversight in commit fc49e24, so backpatch down to 11.

Author: Jie Zhang
Discussion: https://postgr.es/m/970ad9508461469b9450b64027842331@G08CNEXMBPEKD06.g08.fujitsu.local
Backpatch-through: 11

Branch
------
REL_11_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/213e2b7363cd068b9c4481353c3b72729c069b97

Modified Files
--------------
src/bin/pg_basebackup/streamutil.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andreas Andreakis 2020-04-17 04:22:59 Detecting renamed columns via pgouput in logical replication ?
Previous Message David Rowley 2020-04-16 22:30:25 pgsql: Remove unneeded constraint dependency tracking