pgsql: Fix cache reference leak in contrib/sepgsql.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix cache reference leak in contrib/sepgsql.
Date: 2020-04-16 18:46:19
Message-ID: E1jP9Wl-0001Ic-HQ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix cache reference leak in contrib/sepgsql.

fixup_whole_row_references() did the wrong thing with a dropped column,
resulting in a commit-time warning about a cache reference leak.

I (tgl) added a test case exercising this, but back-patched the test
only as far as v10; the patch didn't apply cleanly to 9.6 and it
didn't seem worth the trouble to adapt it. The bug is pretty old
though, so apply the code change all the way back.

Michael Luo, with cosmetic improvements by me

Discussion: https://postgr.es/m/BYAPR08MB5606D1453D7F50E2AF4D2FD29AD80@BYAPR08MB5606.namprd08.prod.outlook.com

Branch
------
REL_10_STABLE

Details
-------
https://git.postgresql.org/pg/commitdiff/f4a42005613bf279b4c1d203112c0583cbbf498e

Modified Files
--------------
contrib/sepgsql/dml.c | 21 ++++++++++-----------
contrib/sepgsql/expected/dml.out | 16 ++++++++++++++--
contrib/sepgsql/sql/dml.sql | 8 ++++++--
3 files changed, 30 insertions(+), 15 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Fujii Masao 2020-04-16 19:50:38 Re: pgsql: When WalSndCaughtUp, sleep only in WalSndWaitForWal().
Previous Message Amit Kapila 2020-04-16 05:38:02 pgsql: Fix the usage of parallel and full options of vacuum command.