pgsql: Code review for backup manifest.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Code review for backup manifest.
Date: 2020-04-15 02:16:01
Message-ID: E1jOXar-0003r2-RQ@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Code review for backup manifest.

This commit prevents pg_basebackup from receiving backup_manifest file
when --no-manifest is specified. Previously, when pg_basebackup was
writing a tarfile to stdout, it tried to receive backup_manifest file even
when --no-manifest was specified, and reported an error.

Also remove unused -m option from pg_basebackup.

Also fix typo in BASE_BACKUP command documentation.

Author: Fujii Masao
Reviewed-by: Michael Paquier, Robert Haas
Discussion: https://postgr.es/m/01e3ed3a-8729-5aaa-ca84-e60e3ca59db8@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/a2ac73e7be7adf2a9248d14322d3a5e055ea4fd0

Modified Files
--------------
doc/src/sgml/protocol.sgml | 10 +++++-----
src/bin/pg_basebackup/pg_basebackup.c | 4 ++--
2 files changed, 7 insertions(+), 7 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-04-15 06:58:41 pgsql: Fix minor memory leak in pg_dump
Previous Message Peter Geoghegan 2020-04-14 21:39:24 pgsql: Remove obsolete "hole in center of page" comment.