pgAdmin 4 commit: Ensure all object names in the title line of the reve

From: Akshay Joshi <akshay(dot)joshi(at)enterprisedb(dot)com>
To: pgadmin-hackers(at)lists(dot)postgresql(dot)org
Subject: pgAdmin 4 commit: Ensure all object names in the title line of the reve
Date: 2020-04-14 08:02:24
Message-ID: E1jOGWW-0006Oj-CB@gothos.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgadmin-hackers

Ensure all object names in the title line of the reverse-engineered SQL are not quoted. Fixes #4445

Branch
------
master

Details
-------
https://git.postgresql.org/gitweb?p=pgadmin4.git;a=commitdiff;h=41521a9b986a1e8331dd452e05bfd2dd0ee53847
Author: Shubham Agarwal <shubham(dot)agarwal(at)enterprisedb(dot)com>

Modified Files
--------------
docs/en_US/release_notes_4_21.rst | 1 +
.../servers/databases/schemas/domains/__init__.py | 12 ++++++-----
.../tests/pg/default/alter_domain_comment.sql | 2 +-
.../pg/default/alter_domain_default_expression.sql | 2 +-
.../domains/tests/pg/default/alter_domain_name.sql | 2 +-
.../tests/pg/default/alter_domain_null_type.sql | 2 +-
.../domains/tests/pg/default/create_domain.sql | 2 +-
.../tests/pg/default/create_domain_numeric.sql | 2 +-
.../tests/ppas/default/alter_domain_comment.sql | 2 +-
.../default/alter_domain_default_expression.sql | 2 +-
.../tests/ppas/default/alter_domain_name.sql | 2 +-
.../tests/ppas/default/alter_domain_null_type.sql | 2 +-
.../domains/tests/ppas/default/create_domain.sql | 2 +-
.../tests/ppas/default/create_domain_numeric.sql | 2 +-
.../databases/schemas/foreign_tables/__init__.py | 11 ++++++----
.../tests/pg/9.2_plus/alter_add_opts.sql | 2 +-
.../tests/pg/9.2_plus/alter_add_priv.sql | 2 +-
.../tests/pg/9.2_plus/alter_col_opts.sql | 2 +-
.../pg/9.2_plus/alter_comment_add_columns.sql | 2 +-
.../tests/pg/9.2_plus/alter_remove_opts_priv.sql | 2 +-
.../create_foreign_table_with_all_options.sql | 2 +-
.../tests/pg/9.6_plus/alter_add_cons_opts.sql | 2 +-
.../tests/pg/9.6_plus/alter_add_priv.sql | 2 +-
.../tests/pg/9.6_plus/alter_col_opts.sql | 2 +-
.../pg/9.6_plus/alter_comment_add_columns.sql | 2 +-
.../pg/9.6_plus/alter_remove_opts_priv_cons.sql | 2 +-
.../create_foreign_table_with_all_options.sql | 2 +-
.../tests/ppas/9.2_plus/alter_add_priv.sql | 2 +-
.../tests/ppas/9.2_plus/alter_column.sql | 2 +-
.../ppas/9.2_plus/alter_comment_add_columns.sql | 2 +-
.../tests/ppas/9.2_plus/alter_remove_priv.sql | 2 +-
.../create_foreign_table_with_all_options.sql | 2 +-
.../tests/ppas/9.6_plus/alter_add_cons_opts.sql | 2 +-
.../tests/ppas/9.6_plus/alter_add_priv.sql | 2 +-
.../tests/ppas/9.6_plus/alter_col_opts.sql | 2 +-
.../ppas/9.6_plus/alter_comment_add_columns.sql | 2 +-
.../ppas/9.6_plus/alter_remove_opts_priv_cons.sql | 2 +-
.../create_foreign_table_with_all_options.sql | 2 +-
.../fts_configurations/sql/default/sql.sql | 4 ++--
.../tests/default/create_fts_conf.sql | 2 +-
.../databases/schemas/fts_dictionaries/__init__.py | 9 ++++----
.../alter_fts_dictionary_delete_options.sql | 2 +-
.../tests/default/alter_fts_dictionary_options.sql | 2 +-
.../tests/default/create_fts_dictionary.sql | 2 +-
.../templates/fts_parsers/sql/default/sql.sql | 4 ++--
.../fts_parsers/tests/default/alter_fts_parser.sql | 2 +-
.../tests/default/create_fts_parser.sql | 2 +-
.../templates/fts_templates/sql/default/sql.sql | 4 ++--
.../fts_templates/tests/default/alter_comment.sql | 2 +-
.../fts_templates/tests/default/alter_rename.sql | 2 +-
.../schemas/fts_templates/tests/default/create.sql | 2 +-
.../databases/schemas/functions/__init__.py | 24 +++++++++++-----------
.../tests/pg/default/alter_ptrig_comment.sql | 2 +-
.../tests/pg/default/alter_ptrig_set_1.sql | 2 +-
.../tests/pg/default/alter_ptrig_set_2.sql | 2 +-
.../tests/pg/default/alter_ptrig_set_3.sql | 2 +-
.../tests/pg/default/create_event_trigger_full.sql | 2 +-
.../tests/pg/default/create_plain_trigger.sql | 2 +-
.../tests/pg/default/create_plain_trigger_full.sql | 2 +-
.../tests/ppas/default/alter_ptrig_comment.sql | 2 +-
.../tests/ppas/default/alter_ptrig_set_1.sql | 2 +-
.../tests/ppas/default/alter_ptrig_set_2.sql | 2 +-
.../tests/ppas/default/alter_ptrig_set_3.sql | 2 +-
.../ppas/default/create_event_trigger_full.sql | 2 +-
.../tests/ppas/default/create_plain_trigger.sql | 2 +-
.../ppas/default/create_plain_trigger_full.sql | 2 +-
.../servers/databases/schemas/packages/__init__.py | 5 ++---
.../10_plus/alter_package_headers_and_comment.sql | 2 +-
.../10_plus/create_package_with_all_options.sql | 2 +-
.../9.2_plus/alter_package_headers_and_comment.sql | 2 +-
.../9.2_plus/create_package_with_all_options.sql | 2 +-
.../databases/schemas/sequences/__init__.py | 13 +++++++-----
.../tests/pg/default/alter_neg_seq_props.sql | 2 +-
.../tests/pg/default/alter_seq_comment.sql | 2 +-
.../tests/pg/default/alter_seq_privs_add.sql | 2 +-
.../tests/pg/default/alter_seq_privs_remove.sql | 2 +-
.../tests/pg/default/alter_seq_privs_update.sql | 2 +-
.../sequences/tests/pg/default/alter_seq_props.sql | 2 +-
.../tests/pg/default/create_negative_sequence.sql | 2 +-
.../sequences/tests/pg/default/create_sequence.sql | 2 +-
.../tests/ppas/default/alter_neg_seq_props.sql | 2 +-
.../tests/ppas/default/alter_seq_comment.sql | 2 +-
.../tests/ppas/default/alter_seq_privs_add.sql | 2 +-
.../tests/ppas/default/alter_seq_privs_remove.sql | 2 +-
.../tests/ppas/default/alter_seq_privs_update.sql | 2 +-
.../tests/ppas/default/alter_seq_props.sql | 2 +-
.../ppas/default/create_negative_sequence.sql | 2 +-
.../tests/ppas/default/create_sequence.sql | 2 +-
.../templates/synonyms/sql/default/create.sql | 4 ++--
.../ppas/9.4_plus/create_public_syn_with_func.sql | 2 +-
.../ppas/9.4_plus/create_public_syn_with_pkg.sql | 2 +-
.../ppas/9.4_plus/create_public_syn_with_proc.sql | 2 +-
.../ppas/9.4_plus/create_public_syn_with_seq.sql | 2 +-
.../ppas/9.4_plus/create_public_syn_with_table.sql | 2 +-
.../ppas/9.4_plus/create_synonyms_with_func.sql | 2 +-
.../ppas/9.4_plus/create_synonyms_with_pkg.sql | 2 +-
.../ppas/9.4_plus/create_synonyms_with_proc.sql | 2 +-
.../ppas/9.4_plus/create_synonyms_with_seq.sql | 2 +-
.../ppas/9.4_plus/create_synonyms_with_table.sql | 2 +-
.../servers/databases/schemas/tables/utils.py | 4 ++--
.../templates/mviews/pg/9.3_plus/sql/create.sql | 2 +-
.../templates/mviews/pg/9.4_plus/sql/create.sql | 2 +-
.../templates/mviews/ppas/9.3_plus/sql/create.sql | 2 +-
.../templates/views/pg/9.1_plus/sql/create.sql | 2 +-
.../templates/views/pg/9.2_plus/sql/create.sql | 2 +-
.../templates/views/pg/9.3_plus/sql/create.sql | 2 +-
.../templates/views/pg/9.4_plus/sql/create.sql | 2 +-
.../templates/views/ppas/9.1_plus/sql/create.sql | 2 +-
.../templates/views/ppas/9.2_plus/sql/create.sql | 2 +-
.../templates/views/ppas/9.3_plus/sql/create.sql | 2 +-
.../templates/views/ppas/9.4_plus/sql/create.sql | 2 +-
.../views/tests/pg/9.4_plus/alter_mview.sql | 2 +-
.../pg/9.4_plus/alter_mview_add_fillfactor.sql | 2 +-
.../9.4_plus/alter_mview_add_table_parameter.sql | 2 +-
.../tests/pg/9.4_plus/alter_mview_definition.sql | 2 +-
.../pg/9.4_plus/alter_mview_drop_all_priv.sql | 2 +-
.../alter_mview_remove_table_parameter.sql | 2 +-
.../schemas/views/tests/pg/9.4_plus/alter_view.sql | 2 +-
.../tests/pg/9.4_plus/alter_view_add_some_priv.sql | 2 +-
.../tests/pg/9.4_plus/alter_view_definition.sql | 2 +-
.../tests/pg/9.4_plus/alter_view_delete_priv.sql | 2 +-
.../views/tests/pg/9.4_plus/create_mview.sql | 2 +-
.../views/tests/pg/9.4_plus/create_view.sql | 2 +-
.../views/tests/ppas/9.4_plus/alter_mview.sql | 2 +-
.../ppas/9.4_plus/alter_mview_add_fillfactor.sql | 2 +-
.../9.4_plus/alter_mview_add_table_parameter.sql | 2 +-
.../tests/ppas/9.4_plus/alter_mview_definition.sql | 2 +-
.../ppas/9.4_plus/alter_mview_drop_all_priv.sql | 2 +-
.../alter_mview_remove_table_parameter.sql | 2 +-
.../views/tests/ppas/9.4_plus/alter_view.sql | 2 +-
.../ppas/9.4_plus/alter_view_add_some_priv.sql | 2 +-
.../tests/ppas/9.4_plus/alter_view_definition.sql | 2 +-
.../tests/ppas/9.4_plus/alter_view_delete_priv.sql | 2 +-
.../views/tests/ppas/9.4_plus/create_mview.sql | 2 +-
.../views/tests/ppas/9.4_plus/create_view.sql | 2 +-
135 files changed, 174 insertions(+), 167 deletions(-)

Browse pgadmin-hackers by date

  From Date Subject
Next Message Akshay Joshi 2020-04-14 08:03:04 Re: [pgAdmin4][Patch]: RM 4445 - Ensure all object names in the title line of the reverse-engineered SQL are *not* quoted.
Previous Message Vishal Sawale 2020-04-14 07:58:04 Re: [pgAdmin RM#1257] Show system XX properties for sequences node