pgsql: Exclude backup_manifest file that existed in database, from BASE

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Exclude backup_manifest file that existed in database, from BASE
Date: 2020-04-09 13:39:36
Message-ID: E1jMXP6-0007kR-Ur@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Exclude backup_manifest file that existed in database, from BASE_BACKUP.

If there is already a backup_manifest file in the database cluster,
it belongs to the past backup that was used to start this server.
It is not correct for the backup being taken now. So this commit
changes pg_basebackup so that it always skips such backup_manifest
file. The backup_manifest file for the current backup will be injected
separately if users want it.

Author: Fujii Masao
Reviewed-by: Robert Haas
Discussion: https://postgr.es/m/78f76a3d-1a28-a97d-0394-5c96985dd1c0@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/1ec50a81ec0acd452c7520de19e607a6de8fba5e

Modified Files
--------------
src/backend/replication/basebackup.c | 8 ++++++++
src/bin/pg_rewind/filemap.c | 8 ++++++++
2 files changed, 16 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2020-04-09 14:42:09 pgsql: Fix CREATE TABLE LIKE INCLUDING GENERATED column order issue
Previous Message Amit Langote 2020-04-09 13:07:03 Re: pgsql: Allow publishing partition changes via ancestors