From: | Jeff Davis <jdavis(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Create memory context for HashAgg with a reasonable maxBlockSize |
Date: | 2020-04-08 04:29:21 |
Message-ID: | E1jM2L3-000497-Kc@gemulon.postgresql.org |
Views: | Whole Thread | Raw Message | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Create memory context for HashAgg with a reasonable maxBlockSize.
If the memory context's maxBlockSize is too big, a single block
allocation can suddenly exceed work_mem. For Hash Aggregation, this
can mean spilling to disk too early or reporting a confusing memory
usage number for EXPLAN ANALYZE.
Introduce CreateWorkExprContext(), which is like CreateExprContext(),
except that it creates the AllocSet with a maxBlockSize that is
reasonable in proportion to work_mem.
Right now, CreateWorkExprContext() is only used by Hash Aggregation,
but it may be generally useful in the future.
Discussion: https://postgr.es/m/412a3fbf306f84d8d78c4009e11791867e62b87c.camel@j-davis.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/50a38f65177ea7858bc97f71ba0757ba04c1c167
Modified Files
--------------
src/backend/executor/execUtils.c | 71 +++++++++++++++++++++++++++++++---------
src/backend/executor/nodeAgg.c | 5 +--
src/include/executor/executor.h | 1 +
3 files changed, 58 insertions(+), 19 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Jeff Davis | 2020-04-08 04:32:04 | Re: pgsql: Allow partitionwise joins in more cases. |
Previous Message | David Rowley | 2020-04-08 04:23:24 | pgsql: Add functions to calculate the next power of 2 |