From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix bogus CALLED_AS_TRIGGER() defenses. |
Date: | 2020-04-03 15:25:16 |
Message-ID: | E1jKOC4-0003ae-F2@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix bogus CALLED_AS_TRIGGER() defenses.
contrib/lo's lo_manage() thought it could use
trigdata->tg_trigger->tgname in its error message about
not being called as a trigger. That naturally led to a core dump.
unique_key_recheck() figured it could Assert that fcinfo->context
is a TriggerData node in advance of having checked that it's
being called as a trigger. That's harmless in production builds,
and perhaps not that easy to reach in any case, but it's logically
wrong.
The first of these per bug #16340 from William Crowell;
the second from manual inspection of other CALLED_AS_TRIGGER
call sites.
Back-patch the lo.c change to all supported branches, the
other to v10 where the thinko crept in.
Discussion: https://postgr.es/m/16340-591c7449dc7c8c47@postgresql.org
Branch
------
REL_11_STABLE
Details
-------
https://git.postgresql.org/pg/commitdiff/7b1552283465acc10a88038fe87c7901198c3b5e
Modified Files
--------------
contrib/lo/lo.c | 3 +--
src/backend/commands/constraint.c | 2 +-
2 files changed, 2 insertions(+), 3 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Tom Lane | 2020-04-03 15:34:23 | Re: pgsql: Include information on buffer usage during planning phase, in EX |
Previous Message | Fujii Masao | 2020-04-03 15:25:05 | Re: pgsql: Include information on buffer usage during planning phase, in EX |