From: | Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Improve stability fix for partition_aggregate test. |
Date: | 2020-04-02 23:44:06 |
Message-ID: | E1jK9VG-0006ST-73@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Improve stability fix for partition_aggregate test.
Instead of disabling autovacuum on these test tables, adjust the
partition boundaries so that the child partitions are not all the
same size. That should cause the planner to use a predictable
ordering of the per-partition scan nodes even in cases where
autovacuum causes the rowcount estimates to be off a bit.
Moreover, this also lets these tests show that the planner does
properly order the tables in descending size order, something
that wasn't being proven before.
The pagg_tab1 and pagg_tab2 partitions are still all the same
size, but that should be fine, because those tables are so small
that (1) autovacuum won't fire on them, and (2) even if it did,
it couldn't change the reltuples value --- with only one page,
it can't see just part of the relation.
Discussion: https://postgr.es/m/24467.1585838693@sss.pgh.pa.us
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7cb0a423f914af6936d13a8c7f2e35c0a4e4bd14
Modified Files
--------------
src/test/regress/expected/partition_aggregate.out | 62 +++++++++++------------
src/test/regress/sql/partition_aggregate.sql | 48 +++++++++---------
2 files changed, 55 insertions(+), 55 deletions(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Robert Haas | 2020-04-03 01:11:41 | pgsql: pg_waldump: Add a --quiet option. |
Previous Message | Bruce Momjian | 2020-04-02 21:42:23 | Re: pgsql: doc: add namespace column to pg_buffercache example query |