pgsql: Improve error messages in ltree_in and lquery_in.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve error messages in ltree_in and lquery_in.
Date: 2020-03-31 15:14:55
Message-ID: E1jJIbP-0001xM-GH@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve error messages in ltree_in and lquery_in.

Ensure that the type name is mentioned in all cases (bare "syntax error"
isn't that helpful). Avoid using the term "level", since that's not
used in the documentation. Phrase error position reports as "at
character N" not "in position N"; the latter seems ambiguous, and it's
certainly not how we say it elsewhere. For the same reason, make the
character position values be 1-based not 0-based. Provide a position
in more cases. (I continued to leave that out of messages complaining
about end-of-input, where it seemed pointless, as well as messages
complaining about overall input complexity, where fingering any one part
of the input would be arbitrary.)

Discussion: https://postgr.es/m/15582.1585529626@sss.pgh.pa.us

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/e07e2a40bd0c3c02a9baf2e5ddccf665e73208fb

Modified Files
--------------
contrib/ltree/expected/ltree.out | 13 ++-
contrib/ltree/ltree_io.c | 99 ++++++++++++----------
contrib/ltree/sql/ltree.sql | 1 +
contrib/ltree_plpython/expected/ltree_plpython.out | 2 +-
4 files changed, 63 insertions(+), 52 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Tom Lane 2020-03-31 15:38:22 pgsql: Back-patch addition of stack overflow and interrupt checks for l
Previous Message Alexander Korotkov 2020-03-31 14:54:17 pgsql: Improve error reporting in opclasscmds.c