pgsql: Fix INSERT OVERRIDING USER VALUE behavior

From: Peter Eisentraut <peter(at)eisentraut(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix INSERT OVERRIDING USER VALUE behavior
Date: 2020-03-31 06:52:12
Message-ID: E1jJAku-0007Vb-LS@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix INSERT OVERRIDING USER VALUE behavior

The original implementation disallowed using OVERRIDING USER VALUE on
identity columns defined as GENERATED ALWAYS, which is not per
standard. So allow that now.

Expand documentation and tests around this.

Author: Dean Rasheed <dean(dot)a(dot)rasheed(at)gmail(dot)com>
Reviewed-by: Peter Eisentraut <peter(dot)eisentraut(at)2ndquadrant(dot)com>
Reviewed-by: Vik Fearing <vik(at)postgresfriends(dot)org>
Discussion: https://www.postgresql.org/message-id/flat/CAEZATCVrh2ufCwmzzM%3Dk_OfuLhTTPBJCdFkimst2kry4oHepuQ%40mail.gmail.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/de3bbfcc962f24c1a20a17b76c604e5973a05817

Modified Files
--------------
doc/src/sgml/ref/create_table.sgml | 30 +++++++++++++++++--------
doc/src/sgml/ref/insert.sgml | 31 +++++++++++++++++--------
doc/src/sgml/ref/update.sgml | 7 ++++--
src/backend/rewrite/rewriteHandler.c | 4 +++-
src/test/regress/expected/identity.out | 41 +++++++++++++++++++++++++---------
src/test/regress/sql/identity.sql | 25 +++++++++++++++++----
6 files changed, 102 insertions(+), 36 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Mahendra Singh Thalor 2020-03-31 07:43:47 Re: pgsql: Allow vacuum command to process indexes in parallel.
Previous Message Michael Paquier 2020-03-31 06:34:22 pgsql: Move routine definitions of xlogarchive.c to a new header file