pgsql: Fix up recent breakage of headerscheck and cpluspluscheck.

From: Tom Lane <tgl(at)sss(dot)pgh(dot)pa(dot)us>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix up recent breakage of headerscheck and cpluspluscheck.
Date: 2020-03-21 22:28:47
Message-ID: E1jFmbn-0002TS-PW@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix up recent breakage of headerscheck and cpluspluscheck.

headerscheck and cpluspluscheck should skip the recently-added
cmdtaglist.h header, since (like kwlist.h and some other similarly-
designed headers) it's not meant to be included standalone.

evtcache.h was missing an #include to support its usage of Bitmapset.

typecmds.h was missing an #include to support its usage of ParseState.

The first two of these were evidently oversights in commit 2f9661311.
I didn't track down exactly which change broke typecmds.h, but it
must have been some rearrangement in one of its existing inclusions,
because it's referenced ParseState for quite a long time and there
were not complaints from these checking programs before.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d0587f52b3bb898db3c0011954de6ae9adc076c8

Modified Files
--------------
src/include/commands/typecmds.h | 2 +-
src/include/tcop/cmdtaglist.h | 2 +-
src/include/utils/evtcache.h | 1 +
src/tools/pginclude/cpluspluscheck | 1 +
src/tools/pginclude/headerscheck | 1 +
5 files changed, 5 insertions(+), 2 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2020-03-22 00:27:22 Re: pgsql: Allow page lock to conflict among parallel group members.
Previous Message Noah Misch 2020-03-21 19:21:31 Re: pgsql: Skip WAL for new relfilenodes, under wal_level=minimal.