From: | Thomas Munro <tmunro(at)postgresql(dot)org> |
---|---|
To: | pgsql-committers(at)lists(dot)postgresql(dot)org |
Subject: | pgsql: Fix kqueue support under debugger on macOS. |
Date: | 2020-03-18 00:05:30 |
Message-ID: | E1jEMDC-0002dg-BA@gemulon.postgresql.org |
Views: | Raw Message | Whole Thread | Download mbox | Resend email |
Thread: | |
Lists: | pgsql-committers |
Fix kqueue support under debugger on macOS.
While running under a debugger, macOS's getppid() can return the
debugger's PID. That could cause a backend to exit because it falsely
believed that the postmaster had died, since commit 815c2f09.
Continue to use getppid() as a fast postmaster check after adding the
postmaster's PID to a kqueue, to close a PID-reuse race, but double
check that it actually exited by trying to read the pipe. The new check
isn't reached in the common case.
Reported-by: Alexander Korotkov <a(dot)korotkov(at)postgrespro(dot)ru>
Discussion: https://postgr.es/m/CA%2BhUKGKhAxJ8V8RVwCo6zJaeVrdOG1kFBHGZOOjf6DzW_omeMA%40mail.gmail.com
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/7bc84a1f304acc9f4705c4178eb362ddce310452
Modified Files
--------------
src/backend/storage/ipc/latch.c | 11 ++++++++++-
1 file changed, 10 insertions(+), 1 deletion(-)
From | Date | Subject | |
---|---|---|---|
Next Message | Thomas Munro | 2020-03-18 00:07:10 | Re: pgsql: Add kqueue(2) support to the WaitEventSet API. |
Previous Message | Tom Lane | 2020-03-17 23:36:49 | pgsql: Refactor our checks for valid function and aggregate signatures. |