pgsql: Improve test coverage for multi-column MCV lists

From: Tomas Vondra <tomas(dot)vondra(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Improve test coverage for multi-column MCV lists
Date: 2020-03-14 22:10:24
Message-ID: E1jDEzA-0001qe-08@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Improve test coverage for multi-column MCV lists

The regression tests for extended statistics were not testing a couple
of important cases for the MCV lists:

* IS NOT NULL clauses - We did have queries with IS NULL clauses, but
not the negative case.

* clauses with variable on the right - All the clauses had the Var on
the left, i.e. (Var op Const), so this adds (Const op Var) too.

* columns with fixed-length types passed by reference - All columns
were using either by-value or varlena types, so add a test with
UUID columns too. This matters for (de)serialization.

* NULL-only dimension - When one of the columns contains only NULL
values, we treat it a a special case during (de)serialization.

* arrays containing NULL - When the constant parameter contains NULL
value, we need to handle it correctly during estimation, for all
IN, ANY and ALL clauses.

Discussion: https://www.postgresql.org/message-id/flat/20200113230008(dot)g67iyk4cs3xbnjju(at)development
Author: Tomas Vondra

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/d8cfa82d51f812f886d06bdc7bb73470e55d74b7

Modified Files
--------------
src/test/regress/expected/stats_ext.out | 237 +++++++++++++++++++++++++++++++-
src/test/regress/sql/stats_ext.sql | 102 +++++++++++++-
2 files changed, 335 insertions(+), 4 deletions(-)

Browse pgsql-committers by date

  From Date Subject
Next Message Peter Eisentraut 2020-03-15 10:23:15 pgsql: Add backend type to csvlog and optionally log_line_prefix
Previous Message Tomas Vondra 2020-03-14 22:10:23 pgsql: Improve test coverage for functional dependencies