pgsql: Fix issues around .pgpass file.

From: Fujii Masao <fujii(at)postgresql(dot)org>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Fix issues around .pgpass file.
Date: 2020-03-05 04:02:50
Message-ID: E1j9hik-0004y8-VI@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Fix issues around .pgpass file.

This commit fixes the following two issues around .pgpass file.

(1) If the length of a line in .pgpass file was larger than 319B,
libpq silently treated each 319B in the line as a separate
setting line.

(2) The document explains that a line beginning with # is treated
as a comment in .pgpass. But there was no code doing such
special handling. Whether a line begins with # or not, libpq
just checked that the first token in the line match with the host.

For (1), this commit makes libpq warn if the length of a line
is larger than 319B, and throw away the remaining part beginning
from 320B position.

For (2), this commit changes libpq so that it treats any lines
beginning with # as comments.

Author: Fujii Masao
Reviewed-by: Hamid Akhtar
Discussion: https://postgr.es/m/c0f0c01c-fa74-9749-2084-b73882fd5465@oss.nttdata.com

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/2eb3bc58814fa1ab86308a3658ddb76081080db3

Modified Files
--------------
src/interfaces/libpq/fe-connect.c | 33 +++++++++++++++++++++++++++++++++
1 file changed, 33 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Michael Paquier 2020-03-05 05:13:03 pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Previous Message Michael Paquier 2020-03-05 03:51:47 pgsql: Fix more issues with dependency handling at swap phase of REINDE