pgsql: Issue properly WAL record for CID of first catalog tuple in mult

From: Michael Paquier <michael(at)paquier(dot)xyz>
To: pgsql-committers(at)lists(dot)postgresql(dot)org
Subject: pgsql: Issue properly WAL record for CID of first catalog tuple in mult
Date: 2020-02-24 22:55:58
Message-ID: E1j6Mdq-0004J8-Dc@gemulon.postgresql.org
Views: Raw Message | Whole Thread | Download mbox | Resend email
Thread:
Lists: pgsql-committers

Issue properly WAL record for CID of first catalog tuple in multi-insert

Multi-insert for heap is not yet used actively for catalogs, but the
code to support this case is in place for logical decoding. The
existing code forgot to issue a XLOG_HEAP2_NEW_CID record for the first
tuple inserted, leading to failures when attempting to use multiple
inserts for catalogs at decoding time. This commit fixes the problem by
WAL-logging the needed CID.

This is not an active bug, so no back-patch is done.

Author: Daniel Gustafsson
Discussion: https://postgr.es/m/E0D4CC67-A1CF-4DF4-991D-B3AC2EB5FAE9@yesql.se

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/7d672b76bf27327dc3527dabcd8be4e2dedf430f

Modified Files
--------------
src/backend/access/heap/heapam.c | 8 ++++++++
1 file changed, 8 insertions(+)

Browse pgsql-committers by date

  From Date Subject
Next Message Andres Freund 2020-02-24 23:27:30 pgsql: expression eval: Reduce number of steps for agg transition invoc
Previous Message Tom Lane 2020-02-24 22:28:41 pgsql: Account explicitly for long-lived FDs that are allocated outside